Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI remove query-string package and unused commit arg #7129

Merged
merged 2 commits into from
Dec 10, 2023
Merged

UI remove query-string package and unused commit arg #7129

merged 2 commits into from
Dec 10, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 8, 2023

Close #7128

@nopcoder nopcoder requested a review from a team December 8, 2023 14:47
@nopcoder nopcoder self-assigned this Dec 8, 2023
@nopcoder nopcoder added area/UI Improvements or additions to UI exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Dec 8, 2023
@nopcoder nopcoder requested review from johnnyaug and a team and removed request for a team December 9, 2023 18:33
arielshaqed
arielshaqed approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would rather have reviewed this as two PRs.

webui/src/lib/api/index.js Show resolved Hide resolved
@nopcoder
Copy link
Contributor Author

Thanks! Would rather have reviewed this as two PRs.

Assume you are talking about the code vs remove the package from package*.json.
Thought because it is a single package this PR will hold.

@nopcoder nopcoder force-pushed the chore/webui-querystring branch from ea32443 to d5cb211 Compare December 10, 2023 11:25
@nopcoder nopcoder enabled auto-merge (squash) December 10, 2023 11:26
@nopcoder nopcoder merged commit 55408a1 into master Dec 10, 2023
35 checks passed
@nopcoder nopcoder deleted the chore/webui-querystring branch December 10, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@johnnyaug johnnyaug Awaiting requested review from johnnyaug

Assignees

@nopcoder nopcoder

Labels
area/UI Improvements or additions to UI exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI unused metarange in commit api
2 participants
@nopcoder @arielshaqed